Conversation
…mes happens during test runs...
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to support default values for simple-type element lists by extending XSimpleList<T>/XList<T> APIs, and adds new XSD feature-test schemas plus a small schema-compilation handling tweak.
Changes:
- Added default-values overloads to
XSimpleList<T>andXList<T>initialization paths. - Added new XSD feature-test schemas (Attributes + Elements) and a new NUnit test file.
- Adjusted
XmlSchemaSet.Compile()error handling inToXmlSchemaSet.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| XObjectsTests/XsdFeatureTests/AttributeFeatureTests.cs | Adds NUnit tests for list-valued attributes (including defaulted attribute lists). |
| XObjectsTests/XObjectsTests.csproj | Adds a folder entry for the new test directory. |
| XObjectsCore/Extensions/GeneralExtensionMethods.cs | Wraps a specific schema compile error with a LinqToXsdException. |
| XObjectsCore/API/XSimpleList.cs | Adds DefaultValues storage + new Initialize overload accepting defaults. |
| XObjectsCore/API/XList.cs | Adds an overload of InitializeFrom that can apply default values. |
| LinqToXsd/Properties/launchSettings.json | Adds launch profiles for generating feature-test schemas. |
| LinqToXsd.Schemas/XsdFeatureTests/Elements/ElementsListTypeWithDefaults.xsd(.cs) | Adds element list schema + generated code using new XSimpleList defaults API. |
| LinqToXsd.Schemas/XsdFeatureTests/Elements/ElementsListType.xsd(.cs) | Adds element list schema + generated code (non-defaulted). |
| LinqToXsd.Schemas/XsdFeatureTests/Attributes/ListTypeWithDefaults.xsd(.cs) | Adds attribute list schema + generated code (includes defaulted attributes). |
| LinqToXsd.Schemas/XsdFeatureTests/Attributes/ListType.xsd(.cs) | Adds attribute list schema + generated code (non-defaulted). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
@copilot please review changes since last review. |
Reviewed the updates on this branch and validated them locally and in Actions (no failed workflow jobs found). I don’t see additional code changes needed at this point. Verification was done on commit |
mamift
force-pushed
the
bug/defaultXTypedList_T_api
branch
from
77945de to
5b61cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSimpleList<T>) did not include the requisite overload for allowing default values for elements of simple types.